Ticket #29 (new defect)

Opened 2 years ago

feh -l and -O should not check for $DISPLAY

Reported by: Liontooth Assigned to: giblet
Priority: normal Milestone:
Component: options Version: 1.3.4
Severity: normal Keywords:
Cc:

Description

I use feh to make a montage in a bash script:

feh -m -W 1024 $FIL.img/$THUMBS/*.jpg -O $FIL.jpg

The man page explains,

-O FILE

"Just save the created montage to FILE without displaying it (use in scripts)."

When I run the script from cron, I get this:

feh ERROR: Can't open X display. It *is* running, yeah?

X is running. If I run the script from the command line, it works.

See Debian bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=373209

options.c has

case 'O':

opt.output = 1; opt.output_file = estrdup(optarg); opt.display = 0; break;

(should "opt.display = 0;" be added to the other options that don't require a display?).

collage.c has

if (!opt.display)

gib_imlib_free_image_and_decache(im_main);

free(s); D_RETURN_(4);

I can't tell why it's not working.